zeroshade commented on code in PR #1454:
URL: https://github.com/apache/iceberg-go/pull/1454#discussion_r3647332054
##########
types.go:
##########
@@ -93,11 +93,11 @@ func (p Properties) GetInt64(key string, defVal int64)
int64 {
return defVal
}
-// PropUInt reads an unsigned-integer property by key. A missing key,
-// an unparseable value, or a negative value returns defVal — PropUInt
+// PropUInt64 reads an unsigned-integer property by key. A missing key,
Review Comment:
Non-blocking (design): `PropUInt`/`PropUInt64` are exported free functions
while `GetBool`/`GetInt`/`GetInt64` are methods on `Properties`. Exporting a
second free function locks in the inconsistent API shape — worth deciding on
one style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
