rdblue commented on a change in pull request #1823:
URL: https://github.com/apache/iceberg/pull/1823#discussion_r550694592
##########
File path: core/src/main/java/org/apache/iceberg/CatalogProperties.java
##########
@@ -31,4 +33,24 @@ private CatalogProperties() {
public static final String HIVE_URI = "uri";
public static final String HIVE_CLIENT_POOL_SIZE = "clients";
public static final int HIVE_CLIENT_POOL_SIZE_DEFAULT = 2;
+
+ public static final String LOCK_IMPL = "lock.impl";
+
+ public static final String LOCK_HEARTBEAT_INTERVAL_MS =
"lock.heartbeat-interval-ms";
+ public static final long LOCK_HEARTBEAT_INTERVAL_MS_DEFAULT =
TimeUnit.SECONDS.toMillis(3);
+
+ public static final String LOCK_HEARTBEAT_TIMEOUT_MS =
"lock.heartbeat-timeout-ms";
+ public static final long LOCK_HEARTBEAT_TIMEOUT_MS_DEFAULT =
TimeUnit.SECONDS.toMillis(15);
+
+ public static final String LOCK_HEARTBEAT_THREADS = "lock.heartbeat-threads";
+ public static final int LOCK_HEARTBEAT_THREADS_DEFAULT = 4;
Review comment:
Why would a lock need more than one heartbeat thread?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
