singhpk234 commented on code in PR #17332:
URL: https://github.com/apache/iceberg/pull/17332#discussion_r3650503506
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1429,6 +1429,67 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/tables/{table}/presign:
+ parameters:
+ - $ref: '#/components/parameters/prefix'
+ - $ref: '#/components/parameters/namespace'
+ - $ref: '#/components/parameters/table'
+
+ post:
+ tags:
+ - Catalog API
+ summary: Refreshes pre-signed URLs for files from a completed scan
planning result
+ description: >
+ Refreshes pre-signed URLs for a set of files that were returned as
part of a
+ previous server-side scan planning result, identified by its plan-id.
+
+
+ This endpoint is intended for lightweight, proactive renewal of
expiring URLs
+ (for example by a background caching daemon) and does not re-evaluate
the
+ table's manifests or any pushed-down filters. It is only available
when the
+ pre-signed-urls access delegation mechanism has been negotiated with
the
+ planTableScan endpoint via the X-Iceberg-Access-Delegation header.
Review Comment:
Presently yes, its very coupled to the scan plan and this api is purely to
support refresh for long running jobs, where the signed url are first issued in
the scan plan call itself.
I believe if this is what we settle then we can make this endpoint
independent of the server side scan planning and support the client side batch
call .... we would ned to collect the pre-signed urls and add this to the
driver so that the driver can pre-signed urls from server and send it to the
tasks and can refresh if required ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]