fallintoplace commented on code in PR #1526:
URL: https://github.com/apache/iceberg-go/pull/1526#discussion_r3650534833
##########
udf/metadata.go:
##########
@@ -733,19 +755,24 @@ type metadata struct {
lazyDefinitionsByID func() map[string]*Definition
}
-func (m *metadata) FormatVersion() int { return
m.FormatVersionValue }
-func (m *metadata) FunctionUUID() uuid.UUID { return *m.UUID }
-func (m *metadata) Location() string { return m.Loc }
-func (m *metadata) Definitions() []*Definition { return
m.DefinitionList }
-func (m *metadata) DefinitionLog() []DefinitionLogEntry { return
m.DefinitionLogList }
-func (m *metadata) Properties() iceberg.Properties { return m.Props }
-func (m *metadata) Secure() bool { return m.SecureValue
}
-func (m *metadata) Doc() string { return m.DocValue }
+func (m *metadata) FormatVersion() int { return m.FormatVersionValue }
+func (m *metadata) FunctionUUID() uuid.UUID { return *m.UUID }
+func (m *metadata) Location() string { return m.Loc }
+func (m *metadata) Definitions() []*Definition { return
cloneSlice(m.DefinitionList) }
Review Comment:
Could this comment be based on stale code? #1444 changed the table metadata
getters to return defensive copies, including Schemas, Snapshots, and
Properties, and that commit is already in this branch’s history. It looks like
the UDF getters here now match the convention on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
