fallintoplace opened a new pull request, #1543: URL: https://github.com/apache/iceberg-go/pull/1543
## What changed Copy view identifiers when constructing a View and when returning Identifier. ## Why View identifiers are slices. New previously retained the caller-owned slice, and Identifier returned that same backing array. Either path allowed external mutation to change the identity of an existing View and affect equality or catalog behavior. The regression test mutates both the constructor input and the getter result. ## Testing - go test ./view - go vet ./view - go test ./... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
