wombatu-kun commented on PR #16388: URL: https://github.com/apache/iceberg/pull/16388#issuecomment-5086642768
@RussellSpitzer @rdblue this has been open since May 18 with no review (it already collected a stale-bot warning). CI is green (56/56) and it still merges cleanly on current `main`, so it is only waiting on a reviewer. `StagedSparkTable.abortStagedChanges()` is an empty `// TODO: clean up`, so a failed atomic CTAS/RTAS leaks the manifests and manifest list already written into the uncommitted transaction. For a staged CREATE the table is never registered, so `removeOrphanFiles` cannot reach those files and they leak permanently. The fix adds a best-effort no-op `Transaction.abortTransaction()` default and wires it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
