yangshangqing95 commented on code in PR #17346:
URL: https://github.com/apache/iceberg/pull/17346#discussion_r3658497094
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##########
@@ -467,6 +467,127 @@ public void testAllManifestsTableHonorsIgnoreResiduals()
throws IOException {
validateTaskScanResiduals(scan2, true);
}
+ @TestTemplate
+ public void testAllManifestsTableNegatedPredicateOnNonSnapshotColumn()
throws IOException {
Review Comment:
Thanks for flagging this. I’d prefer to keep the `test` prefix here for
consistency with the existing methods in these files, so the new tests don’t
stand out unnecessarily. If the project-wide naming convention is updated
later, these can be renamed together as part of that cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
