anoopj commented on code in PR #16294: URL: https://github.com/apache/iceberg/pull/16294#discussion_r3658540862
########## format/spec.md: ########## @@ -1908,6 +1910,12 @@ Reading v4 metadata: * Relative paths must be resolved against the table location before use (see [Path Resolution](#path-resolution)) * When `location` is omitted, the table location must be provided (see [Table Location Specification](#table-location-specification)) +Snapshot timestamp changes: + +* A snapshot's `timestamp-ms` must be strictly greater than the `timestamp-ms` of its parent snapshot on the same branch. Review Comment: Thanks for adding this. BTW this is almost identical to Delta Lake's [In-commit timestamps](https://github.com/delta-io/delta/blob/master/PROTOCOL.md#in-commit-timestamps) feature which also adds Lamport clocks to commits. (which is awesome!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
