danielcweeks commented on code in PR #16958:
URL: https://github.com/apache/iceberg/pull/16958#discussion_r3661551959
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -33,13 +33,9 @@
class TestTrackedFileStruct {
private static final int FORMAT_VERSION_V4 = 4;
- private static final Types.StructType PARTITION_TYPE =
- Types.StructType.of(
- Types.NestedField.optional(1000, "id_bucket",
Types.IntegerType.get()),
- Types.NestedField.optional(1001, "category",
Types.StringType.get()));
private static final List<Types.NestedField> FIELDS =
Review Comment:
This name is confusing based on how it's defined. It looks like it's
supposed to be empty, but can only assume we're holding the default read
fields, right? Why not call it something more like `DEFAULT_FIELDS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
