uros-b commented on code in PR #17391:
URL: https://github.com/apache/iceberg/pull/17391#discussion_r3664064168
##########
core/src/test/java/org/apache/iceberg/TestFileGenerationUtil.java:
##########
@@ -101,12 +115,32 @@ void testBoundsForAllMetricsModes(String metricsMode) {
ImmutableMap.of() /* no lower bounds */,
ImmutableMap.of() /* no upper bounds */);
- checkBounds(metrics, metricsConfig);
+ checkBounds(SCHEMA, metrics, metricsConfig);
+ }
+
+ @Test
+ public void testBoundsForNestedTypes() {
+ MetricsConfig metricsConfig = MetricsConfig.getDefault();
Review Comment:
Here we only use `MetricsConfig.getDefault()`, but the new key code path for
a nested field is never exercised under non-default modes (none, counts,
truncate).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
