xanderbailey commented on code in PR #2918:
URL: https://github.com/apache/iceberg-rust/pull/2918#discussion_r3664536108
##########
crates/iceberg/src/catalog/utils.rs:
##########
@@ -120,3 +122,93 @@ async fn delete_data_files(io: &FileIO, manifest_paths:
&HashSet<String>) -> Res
})
.await
}
+
+#[cfg(test)]
+mod tests {
Review Comment:
Is there harm in a targeted unit test here? It's a little harder to write
good tests at the catalog level because we block commits today
([link](https://github.com/apache/iceberg-rust/pull/2626)) but I'd be happy to
create an issue to add these regression tests in `crates/catalog/loader/tests`
if that works for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
