pvary commented on code in PR #17296:
URL: https://github.com/apache/iceberg/pull/17296#discussion_r3665141938


##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -756,6 +756,8 @@ private static final class RowIdVectorReader extends 
VectorizedArrowReader {
     private final VectorizedReader<VectorHolder> idReader;
     private final VectorizedReader<VectorHolder> posReader;
     private NullabilityHolder nulls;
+    private BigIntVector vec;
+    private int resultBatchSize = DEFAULT_BATCH_SIZE;

Review Comment:
   nit: Could we call it `batchSize` as we do in the other readers?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to