fallintoplace opened a new pull request, #1593: URL: https://github.com/apache/iceberg-go/pull/1593
## What changed Apply structural partition-field and partition-spec validation during JSON decoding. Reject invalid spec IDs, missing or non-positive source IDs, empty and duplicate names, duplicate field IDs, redundant definitions, and invalid transforms. The validation remains independent of the current schema so historical specs may still reference dropped source columns. ## Why The JSON path directly populated internal fields and bypassed invariants enforced by the constructor. Malformed standalone specs and historical table specs could therefore enter the model and be serialized again. ## Testing - `go test . -run 'Test(PartitionFieldUnmarshalJSON|PartitionSpecUnmarshalRejectsInvalidStructure|DeserializePartitionSpec)' -count=1`\n- `go test ./table -run 'TestRejectStructurallyInvalidHistoricalPartitionSpec$' -count=1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
