smaheshwar-pltr commented on code in PR #17404:
URL: https://github.com/apache/iceberg/pull/17404#discussion_r3670158757
##########
.palantir/revapi.yml:
##########
@@ -564,6 +564,10 @@ acceptedBreaks:
- code: "java.field.removedWithConstant"
old: "field
org.apache.iceberg.PartitionStatsHandler.PARTITION_FIELD_NAME"
justification: "Removed deprecated functionality for partition stats"
+ - code: "java.method.removed"
+ old: "method java.lang.String
org.apache.iceberg.encryption.StandardEncryptionManager::addManifestListKeyMetadata(org.apache.iceberg.encryption.NativeEncryptionKeyMetadata)"
+ justification: "Replaced by pure
StandardEncryptionManager.mintManifestListKey;\
+ \ the immutable, metadata-sourced manager no longer stores minted keys"
Review Comment:
this is significant. what should we actually do here. i didn't realise
`StandardEncryptionManager` was public so this whole PR might be infeasible....
can u look at github history to work out what the standard procedure is for
this stuff? do we need to go through deprecation or cycle or are we just
screwed here given we're changing a public class? can u multiple precedences
for this with for / against?
i'm unconvinced we can "just do this"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
