wgtmac commented on code in PR #801:
URL: https://github.com/apache/iceberg-cpp/pull/801#discussion_r3675790867
##########
src/iceberg/inspect/snapshots_table.h:
##########
@@ -40,6 +40,13 @@ class ICEBERG_EXPORT SnapshotsTable : public MetadataTable {
Kind kind() const noexcept override { return Kind::kSnapshots; }
+ /// \brief Scan all snapshots as rows.
+ ///
+ /// The snapshots table always returns every known snapshot, so the
+ /// snapshot_selection parameter is ignored.
+ Result<ArrowArray> Scan(
Review Comment:
This override hides the zero-argument `MetadataTable::Scan()` overload under
C++ name lookup. A caller using the public `SnapshotsTable::Make()` result
cannot write `snapshots_table->Scan()`; only callers typed as `MetadataTable`
compile, which is why the current tests miss it. Please add `using
MetadataTable::Scan;` (or an explicit zero-argument overload).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
