dramaticlly commented on code in PR #17412: URL: https://github.com/apache/iceberg/pull/17412#discussion_r3677269688
########## api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java: ########## Review Comment: nit, not related but I think required field in optional struct means it can be null, we can skip because all values are null (value count = 5 and null count = 5 for field 104) ########## api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java: ########## Review Comment: nit, not related to the change but I think required field in optional struct means it can be null, we can skip because all values are null (value count = 5 and null count = 5 for field 104) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
