rdblue commented on a change in pull request #2025:
URL: https://github.com/apache/iceberg/pull/2025#discussion_r551458894
##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -114,6 +114,10 @@ public void
preCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTable)
hmsTable.getParameters().put(InputFormatConfig.EXTERNAL_TABLE_PURGE,
"TRUE");
}
+ // For a table created by Hive DDL to be readable by Impala, we need the
Input and OutputFormat set explicitly
+
hmsTable.getSd().setInputFormat(HiveIcebergInputFormat.class.getCanonicalName());
+
hmsTable.getSd().setOutputFormat(HiveIcebergOutputFormat.class.getCanonicalName());
+
Review comment:
These are going to be overwritten by `HiveTableOperations` depending on
whether Hive is enabled. I think the right fix is to set the property to enable
Hive on the table when creating an Iceberg table with the meta hook. @pvary,
what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
