RussellSpitzer commented on code in PR #17424:
URL: https://github.com/apache/iceberg/pull/17424#discussion_r3679307155
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantShreddingAnalyzer.java:
##########
@@ -471,6 +469,112 @@ public void testUuidFieldIsTrackedAndShredded() {
.isInstanceOf(LogicalTypeAnnotation.UUIDLogicalTypeAnnotation.class);
}
+ @Test
+ public void testMixedPrimitiveTypesFieldNotShredded() {
Review Comment:
I forget where we landed on this but I think new tests follow Junit 5 and
don't include "test" but I guess this file already has lots of them... I forget
what the community decided. Probably can stay as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
