superdiaodiao commented on PR #2875: URL: https://github.com/apache/iceberg-rust/pull/2875#issuecomment-5127697434
@hsiang-c Thanks for working on this! Following @CTTY's review above, I have a ready branch that matches Java's `URLEncoder` (`application/x-www-form-urlencoded`) semantics exactly — space → `+`, `*` kept, uppercase `%XX`, per-byte UTF-8 — implemented as a small dependency-free helper, with tests mirroring Java's `TestPartitionPaths#testEscapedFieldNames` and `TestLocationProvider#testEncodedFieldNameInPartitionPath`: https://github.com/superdiaodiao/iceberg-rust/tree/url-encode-partition-paths. Happy to open it as an alternative PR if you don't have bandwidth to continue, or feel free to cherry-pick from it into this one — either way works for me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
