nastra commented on PR #17394: URL: https://github.com/apache/iceberg/pull/17394#issuecomment-5127785325
I did a quick analysis and we have the same pattern in, so we might want to update those places as well to be consistent - `util/BinaryUtil#truncateBinary(ByteBuffer, int)` - `util/BinaryUtil#truncateBinaryUnsafe(ByteBuffer, int)` - `io/FileIO#properties()` - `formats/ReadBuilder#split(long, long)`, `#caseSensitive(boolean)`, `#filter(Expression)` — siblings `set`/`setAll` already say "@return this for method chaining" - `TrackingBuilder#added`, `#from`, `#deleted`, `#replaced` - `TrackedFile#copyWithStats(Set)` - `MetricsConfig#forTable(Table)` - `ManifestFilterManager#buildSummary(Iterable)` - `MergingSnapshotProducer#addedDeleteFiles(...)` - `data/avro/RawDecoder#create(...)` - `encryption/NativeFileCryptoParameters#create(ByteBuffer)` - `io/PartitionedWriter#partition(T)` and `io/PartitionedFanoutWriter#partition(T)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
