nssalian commented on code in PR #16836: URL: https://github.com/apache/iceberg/pull/16836#discussion_r3684535721
########## format/spec.md: ########## @@ -244,6 +244,8 @@ A **`map`** is a collection of key-value pairs with a key type and a value type. A **`variant`** is a value that stores semi-structured data. The structure and data types in a variant are not necessarily consistent across rows in a table or data file. The variant type and binary encoding are defined in the [Parquet project](https://github.com/apache/parquet-format/blob/master/VariantEncoding.md), with support currently available for V1. Support for Variant is added in Iceberg v3. +The `variant` type is a semi-structured type. It is neither a primitive type nor a nested type. Review Comment: Could follow the above paragraph and tighten a bit: ``` As a semi-structured type, `variant` is neither a primitive type nor a nested type. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
