rdblue commented on a change in pull request #2021:
URL: https://github.com/apache/iceberg/pull/2021#discussion_r551612869
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDelete.scala
##########
@@ -77,7 +61,7 @@ object RewriteDelete extends Rule[LogicalPlan] with
PredicateHelper with Logging
val writeInfo = newWriteInfo(r.schema)
val mergeBuilder = r.table.asMergeable.newMergeBuilder("delete",
writeInfo)
- val scanPlan = buildScanPlan(r.table, r.output, mergeBuilder, cond)
+ val scanPlan = buildScanPlan(spark, r.table, r.output, mergeBuilder,
Some(cond))
Review comment:
I would prefer to keep changes for MERGE INTO separate from DELETE FROM
right now. That will keep PRs smaller and we can focus on getting MERGE INTO
right, without the distraction of sometimes breaking DELETE FROM. Once we are
happy with it, then we can refactor to produce common utilities.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
