gaborkaszab commented on code in PR #17438:
URL: https://github.com/apache/iceberg/pull/17438#discussion_r3685474348
##########
core/src/main/java/org/apache/iceberg/DeletionVectorStruct.java:
##########
Review Comment:
I haven't added key_metadata here. I think we should rather drop `equals()`
and `hashCode`. We agreed such metadata structs shouldn't override these. Will
remove them in a follow-up PR.
##########
core/src/main/java/org/apache/iceberg/DeletionVector.java:
##########
@@ -45,9 +46,15 @@ interface DeletionVector {
"cardinality",
Types.LongType.get(),
"Number of set bits (deleted rows) in the vector");
+ Types.NestedField KEY_METADATA =
+ Types.NestedField.optional(
+ 149,
Review Comment:
[ColumnFiles PR](https://github.com/apache/iceberg/pull/16285) takes field
IDs 158-169. I see 149 is free
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
