danielcweeks commented on code in PR #17434:
URL: https://github.com/apache/iceberg/pull/17434#discussion_r3686127259
##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -114,14 +109,16 @@ class TestV4ManifestReader {
null);
// shared data files: FILE_A is in partition id=1, FILE_B in partition id=2
- private static final TrackedFile FILE_A = dataFile("data-a.parquet",
partition(1));
- private static final TrackedFile FILE_B = dataFile("data-b.parquet",
partition(2));
- private static final TrackedFile EQ_DELETES_A =
deleteFile("eq-deletes-a.parquet", partition(1));
- private static final TrackedFile EQ_DELETES_B =
deleteFile("eq-deletes-b.parquet", partition(2));
+ private static final TrackedFile FILE_A =
dataFile("s3://bucket/data-a.parquet", partition(1));
Review Comment:
I don't think this is the right way to update the tests. The default going
forward will be relative and it appears we switched the datafiles to absolute,
but now they don't reflect the default expected behavior.
I think it makes more sense to update where we're validating locations to
compare the resolved location rather than changing the content of the manifests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
