ebyhr commented on code in PR #3707:
URL: https://github.com/apache/iceberg-python/pull/3707#discussion_r3688702849
##########
tests/table/test_inspect.py:
##########
@@ -68,3 +68,15 @@ def
test_inspect_entries_and_files_render_null_bound(catalog: InMemoryCatalog) -
files_metrics = tbl.inspect.files().to_pydict()["readable_metrics"][0]["s"]
assert files_metrics["lower_bound"] is None
assert files_metrics["upper_bound"] is None
+
+
+def test_inspect_snapshots_preserves_null_operation(catalog: InMemoryCatalog)
-> None:
+ schema = Schema(NestedField(1, "s", StringType(), required=False))
Review Comment:
`required=False` looks redundant.
##########
tests/table/test_inspect.py:
##########
@@ -68,3 +68,15 @@ def
test_inspect_entries_and_files_render_null_bound(catalog: InMemoryCatalog) -
files_metrics = tbl.inspect.files().to_pydict()["readable_metrics"][0]["s"]
assert files_metrics["lower_bound"] is None
assert files_metrics["upper_bound"] is None
+
+
+def test_inspect_snapshots_preserves_null_operation(catalog: InMemoryCatalog)
-> None:
+ schema = Schema(NestedField(1, "s", StringType(), required=False))
+ tbl = catalog.create_table("default.snapshot_without_summary", schema)
+ tbl.append(pa.table({"s": ["value"]}, schema=pa.schema([pa.field("s",
pa.large_string(), nullable=True)])))
Review Comment:
`nullable=True` looks redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
