HenryCaiHaiying commented on code in PR #17025:
URL: https://github.com/apache/iceberg/pull/17025#discussion_r3696518195
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -192,6 +205,7 @@ private void commit(boolean partialCommit) {
e);
} finally {
commitState.endCurrentCommit();
+ coordinatorMetrics.recordCommit(partialCommit, (System.nanoTime() -
start) / 1_000L);
Review Comment:
The sensor is to record the total time spent on commit activities whether
the final result is successful or not, I can update the sensor description to
reflect this. But if you feel it is important to distinguish between the time
spend on successful case vs failure cases, I can also add a tag to the sensor
to distinguish between the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
