gtrettenero commented on code in PR #17490:
URL: https://github.com/apache/iceberg/pull/17490#discussion_r3701965698
##########
core/src/test/java/org/apache/iceberg/TestSnapshotChanges.java:
##########
@@ -39,6 +43,30 @@ public class TestSnapshotChanges {
// Partition spec used to create tables
protected static final PartitionSpec SPEC =
PartitionSpec.builderFor(SCHEMA).build();
+ private static final Map<Integer, Long> COLUMN_SIZES = ImmutableMap.of(3,
20L);
+ private static final Map<Integer, Long> VALUE_COUNTS = ImmutableMap.of(3,
1L);
+ private static final Map<Integer, Long> NULL_VALUE_COUNTS =
ImmutableMap.of(3, 0L);
+ private static final Map<Integer, ByteBuffer> LOWER_BOUNDS =
+ ImmutableMap.of(3, Conversions.toByteBuffer(Types.IntegerType.get(), 1));
+ private static final Map<Integer, ByteBuffer> UPPER_BOUNDS =
+ ImmutableMap.of(3, Conversions.toByteBuffer(Types.IntegerType.get(), 2));
+
+ private static final DataFile FILE_WITH_STATS =
Review Comment:
Added NAN_VALUE_COUNTS to the Metrics fixture with assertions in both the
retain-default and skip tests. Also added the file_format and content
assertions. The projection check for content is
testIncludeColumnStatsFalseRetainsDeleteFileFields, which fails if delete
manifests use the data projection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
