zhjwpku commented on code in PR #869:
URL: https://github.com/apache/iceberg-cpp/pull/869#discussion_r3702096831
##########
src/iceberg/test/rewrite_files_test.cc:
##########
@@ -83,18 +84,30 @@ class RewriteFilesTest : public MinimalUpdateTestBase {
return f;
}
- std::shared_ptr<DataFile> MakeDeleteFile(const std::string& path, int64_t
partition_x) {
- auto f = MakeDataFile(path, partition_x);
- f->content = DataFile::Content::kPositionDeletes;
- return f;
+ std::shared_ptr<DataFile> MakePositionDeleteFile(
+ const std::string& path, int64_t partition_x,
+ const std::string& referenced_data_file) {
+ std::string effective_path = path;
+ if (table_->metadata()->format_version >= 3 &&
effective_path.ends_with(".parquet")) {
+ effective_path = effective_path.substr(0, effective_path.size() - 7) +
".puffin";
Review Comment:
nit: will this end with `..puffin`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
