pvary commented on code in PR #17365:
URL: https://github.com/apache/iceberg/pull/17365#discussion_r3704715513


##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java:
##########
@@ -251,24 +254,78 @@ public void testColumnStatisticsEnabled() throws 
Exception {
             optional(1, "int_field", IntegerType.get()),
             optional(2, "string_field", Types.StringType.get()));
 
+    writeAndAssertColumnStatistics(
+        schema,

Review Comment:
   Could we use the same schema for all of the tests?
   Maybe use a constant schema, and use the column names of that schema in the 
properties map, and the expected statistics map below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to