fallintoplace commented on code in PR #1575:
URL: https://github.com/apache/iceberg-go/pull/1575#discussion_r3705872965
##########
manifest_test.go:
##########
@@ -2969,6 +2969,82 @@ func (m *ManifestTestSuite)
TestManifestEntryPresentEmptyListSurvivesRewrite() {
"present-empty column_sizes must survive a decode -> re-encode
rewrite as a present array")
}
+func (m *ManifestTestSuite)
TestDataFileMetadataIsIsolatedFromExternalMutation() {
Review Comment:
I traced this through twmb/avro. Its `[]byte` decoder allocates a new slice
and copies the bytes
[here](https://github.com/twmb/avro/blob/v1.7.2/deser.go#L343-L357), so the
decoded value does not alias the encoded input or reader buffer.
I don’t think mutating source bytes tests a real failure mode here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
