danielcweeks commented on code in PR #17434:
URL: https://github.com/apache/iceberg/pull/17434#discussion_r3708110501
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -146,6 +151,22 @@ private TrackedFile prepare(TrackedFile trackedFile) {
return trackedFile;
}
+ // resolves stored locations against the table location
+ private TrackedFile copyResolved(TrackedFile trackedFile) {
+ TrackedFileStruct copy = (TrackedFileStruct) trackedFile.copy();
Review Comment:
>Although we may not have the thread safety issue with the setter approach
here, I would still love to maintain the immutability of TrackedFileStruct.
@stevenzwu, immutability is not really a expected characteristic here. In
fact, we'll likely move to a model where we reuse the objects (prior readers
heavily leverage reuse to improve performance). Requiring immutability results
in a lot of object thrashing.
I think there are other ways to optimize but the cases where it adds value
are really narrow and we should focus on those later if they actually become a
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
