fallintoplace commented on code in PR #1627:
URL: https://github.com/apache/iceberg-go/pull/1627#discussion_r3708416662


##########
manifest.go:
##########
@@ -1594,6 +1598,19 @@ func NewManifestListWriterV3(out io.Writer, snapshotId, 
sequenceNumber, firstRow
        })
 }
 
+func advanceRowID(firstRowID, existingRows, addedRows int64) (int64, error) {
+       if existingRows < 0 || addedRows < 0 {

Review Comment:
   Thank you for the review, I handled the case here 
[1014f6e](https://github.com/apache/iceberg-go/pull/1627/commits/1014f6ebf29215999fea059ecbc7ad258616f9e7).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to