CTTY commented on code in PR #2871:
URL: https://github.com/apache/iceberg-rust/pull/2871#discussion_r3708550017
##########
crates/iceberg/src/writer/file_writer/location_generator.rs:
##########
@@ -58,8 +64,8 @@ impl DefaultLocationGenerator {
let table_location = table_metadata.location();
let prop = table_metadata.properties();
let configured_data_location = prop
- .get(WRITE_DATA_LOCATION)
- .or(prop.get(WRITE_FOLDER_STORAGE_LOCATION));
+ .get(TableProperties::PROPERTY_WRITE_DATA_LOCATION)
+
.or(prop.get(TableProperties::PROPERTY_WRITE_FOLDER_STORAGE_LOCATION));
Review Comment:
nit: Since now we moved the properties to `TableProperties`, let's use the
typed fields directly here
```rust
let configured_data_location = table_metadata
.write_data_location
.as_ref()
.or(table_metadata.write_folder_storage_location.as_ref());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
