openinx commented on a change in pull request #1893:
URL: https://github.com/apache/iceberg/pull/1893#discussion_r551986989
##########
File path: flink/src/main/java/org/apache/iceberg/flink/IcebergTableSource.java
##########
@@ -122,6 +135,24 @@ public boolean isLimitPushedDown() {
@Override
public TableSource<RowData> applyLimit(long newLimit) {
- return new IcebergTableSource(loader, schema, properties, projectedFields,
true, newLimit);
+ return new IcebergTableSource(loader, schema, properties, projectedFields,
true, newLimit, filters);
+ }
+
+ @Override
+ public TableSource<RowData> applyPredicate(List<Expression> predicates) {
+ List<org.apache.iceberg.expressions.Expression> expressions =
Lists.newArrayList();
+ for (Expression predicate : predicates) {
+ Optional<org.apache.iceberg.expressions.Expression> expression =
FlinkFilters.convert(predicate);
+ if (expression.isPresent()) {
+ expressions.add(expression.get());
+ }
+ }
Review comment:
nit: how about rewrite those as:
```java
List<org.apache.iceberg.expressions.Expression> expressions =
Lists.newArrayList();
for (Expression predicate : predicates) {
FlinkFilters.convert(predicate).ifPresent(expressions::add);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
