Copilot commented on code in PR #3750:
URL: https://github.com/apache/iceberg-python/pull/3750#discussion_r3714028258
##########
tests/cli/test_console.py:
##########
@@ -506,6 +506,17 @@ def
test_properties_get_namespace_specific_empty_property(catalog: InMemoryCatal
assert result.output == "\n"
+def test_properties_get_namespace_specific_property_that_doesnt_exist(
+ catalog: InMemoryCatalog, namespace_properties: Properties
+) -> None:
+ catalog.create_namespace(TEST_TABLE_NAMESPACE, namespace_properties)
+
+ runner = CliRunner()
+ result = runner.invoke(run, ["properties", "get", "namespace", "default",
"doesnotexist"])
Review Comment:
This line is fairly long and may violate configured line-length rules (or
reduce readability). Consider wrapping the arguments across multiple lines in
the existing style used elsewhere in this test module.
##########
tests/cli/test_console.py:
##########
@@ -506,6 +506,17 @@ def
test_properties_get_namespace_specific_empty_property(catalog: InMemoryCatal
assert result.output == "\n"
+def test_properties_get_namespace_specific_property_that_doesnt_exist(
Review Comment:
Test names in this file appear to use `does_not` (see
`test_properties_get_namespace_does_not_exist` below). Renaming this test to
use `does_not` (e.g., `..._that_does_not_exist`) would keep naming consistent
and improve grep-ability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
