anoopj commented on code in PR #2956:
URL: https://github.com/apache/iceberg-rust/pull/2956#discussion_r3714182763
##########
crates/catalog/glue/src/schema.rs:
##########
@@ -157,12 +157,10 @@ impl SchemaVisitor for GlueSchemaBuilder {
PrimitiveType::Date => "date".to_string(),
PrimitiveType::Timestamp => "timestamp".to_string(),
PrimitiveType::TimestampNs => "timestamp_ns".to_string(),
- PrimitiveType::Timestamptz | PrimitiveType::TimestamptzNs => {
- return Err(Error::new(
- ErrorKind::FeatureUnsupported,
- format!("Conversion from {p:?} is not supported"),
- ));
- }
+ // Glue has no timezone-aware timestamp type; map to the
equivalent non-tz type,
+ // matching the behavior of Spark's Glue catalog integration.
Review Comment:
This is technically not in Spark's integration. It's part of the AWS module
of apache/iceberg.
##########
crates/catalog/glue/src/schema.rs:
##########
@@ -157,12 +157,10 @@ impl SchemaVisitor for GlueSchemaBuilder {
PrimitiveType::Date => "date".to_string(),
PrimitiveType::Timestamp => "timestamp".to_string(),
PrimitiveType::TimestampNs => "timestamp_ns".to_string(),
- PrimitiveType::Timestamptz | PrimitiveType::TimestamptzNs => {
- return Err(Error::new(
- ErrorKind::FeatureUnsupported,
Review Comment:
there is a clippy unused imports warning, probably because we aren't using
`Error` and `ErrorKind` anymore.
##########
crates/catalog/glue/src/schema.rs:
##########
Review Comment:
```suggestion
use iceberg::Result;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
