kevinjqliu commented on code in PR #3718: URL: https://github.com/apache/iceberg-python/pull/3718#discussion_r3714417479
########## mkdocs/docs/cli.md: ########## @@ -240,3 +240,17 @@ Property write.metadata.delete-after-commit.enabled removed from nyc.taxis ➜ pyiceberg properties get table nyc.taxis write.metadata.delete-after-commit.enabled Could not find property write.metadata.delete-after-commit.enabled on nyc.taxis ``` + +You can drop a table from the catalog: + +```sh +➜ pyiceberg drop table nyc.taxis +Dropped table: nyc.taxis +``` + +To also purge the table files through the configured catalog, pass `--purge`: Review Comment: ```suggestion To request purge for the underlying table files through the configured catalog, pass `--purge`: ``` the `purge` option is a request to delete, the catalog might not honor it https://github.com/apache/iceberg/blob/949d47a01d0e0bf1b7605e96d1890242f13074c0/open-api/rest-catalog-open-api.yaml#L1236-L1239 maybe something like this ########## pyiceberg/cli/console.py: ########## @@ -269,13 +269,17 @@ def drop() -> None: @drop.command() @click.argument("identifier") [email protected]("--purge", is_flag=True, help="Physically delete all table files.") Review Comment: nit: can we set this default to False to not break the existing behavior? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
