fallintoplace opened a new pull request, #1653: URL: https://github.com/apache/iceberg-go/pull/1653
This test used to accept any non-empty scan result, so it could pass if a same-snapshot equality delete removed one of the rows. This changes the fixture to write a real data file with table.WriteRecords, adds the data file and equality delete in one RowDelta, and asserts that both ids remain visible. Tests: - go test ./table -run '^TestEqualityDeleteDoesNotAffectSameSnapshot$' -count=1 - go test ./table -count=1 - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
