alexandre-normand commented on issue #1666: URL: https://github.com/apache/iceberg-go/issues/1666#issuecomment-5198251331
> I’m so sorry for opening this PR [#1673](https://github.com/apache/iceberg-go/pull/1673) without noticing this issue first. I should have checked more carefully before starting the work. > > Would you mind if I leave it open? I hadn't actually started working on the fix yet but I wanted to get the issue created to capture my findings so your PR is actually very appreciated and the timing is quite good. I do wonder while we're in there if we should check if other paths writing to blob storage suffer for the same flawed logic (failing to check for Close errors before assuming that writes are successful) but we can take that discussion over to the PR. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
