stevenzwu commented on code in PR #17523:
URL: https://github.com/apache/iceberg/pull/17523#discussion_r3731055948
##########
api/src/main/java/org/apache/iceberg/encryption/EncryptingFileIO.java:
##########
@@ -120,15 +121,24 @@ public InputFile newInputFile(ManifestFile manifest) {
}
@Override
- public InputFile newInputFile(ManifestListFile manifestList) {
- if (manifestList.encryptionKeyID() != null) {
- ByteBuffer keyMetadata = manifestList.decryptKeyMetadata(em);
- return newDecryptingInputFile(manifestList.location(), keyMetadata);
+ public InputFile newInputFile(SnapshotFile snapshotFile) {
+ if (snapshotFile.encryptionKeyID() != null) {
+ ByteBuffer keyMetadata = snapshotFile.decryptKeyMetadata(em);
+ return newDecryptingInputFile(snapshotFile.location(), keyMetadata);
} else {
- return newInputFile(manifestList.location());
+ return newInputFile(snapshotFile.location());
}
}
+ /**
+ * @deprecated since 1.13.0; use {@link #newInputFile(SnapshotFile)}.
Review Comment:
1. good point. will update to 1.12.0 for now. if this lands after 1.12.0
release, I will update it again
2. will add 2.0.0 removal note too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
