alexandre-normand commented on code in PR #1673:
URL: https://github.com/apache/iceberg-go/pull/1673#discussion_r3731545251
##########
table/snapshot_producers.go:
##########
@@ -1328,6 +1364,12 @@ func (sp *snapshotProducer)
commitManifests(newManifests, addedContent []iceberg
return nil, fmt.Errorf("rebuild manifest list:
write: %w", wErr)
}
}
+ if closeErr := closeManifestListOutput(fio, manifestListPath,
out, writer, false); closeErr != nil {
+ closed = true
+
+ return nil, fmt.Errorf("rebuild manifest list: close:
%w", closeErr)
+ }
+ closed = true
Review Comment:
Thanks, I think the updated version does look a lot better ❤️ .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
