badalprasadsingh opened a new pull request, #1688: URL: https://github.com/apache/iceberg-go/pull/1688
### Description Fixes #1687 Right now, `UpdateSchema.addColumn` and `unionAddColumn` resolved the parent field against the original schema without checking whether that parent was already staged for deletion in the same builder chain. This let `Apply()`/`Commit()` succeed while silently dropping the newly added nested column, because `applyChanges.Field` drops deleted fields (and everything staged under them) before considering pending additions. Added an explicit `u.isDeleted(parentID)` check right after resolving the parent field in both `addColumn` and `unionAddColumn`, returning an error instead of silently staging an addition that will be discarded. ### Testing Added: the required **regression** tests for it along with, a **symmetry** test and an, **invariant** test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
