steveloughran commented on PR #17457: URL: https://github.com/apache/iceberg/pull/17457#issuecomment-5209479175
The 8 MB came from AWS S3 engineers, so I'd go with that. As for the other comments, unambitious is more likely to get reviewed by a committer. I am not one, no longer actively doing any software dev, just doing spare time reviewing. I would at least recommend designing the http response handling such that if it were factored out then it's easy to find. And that 403 response is probably the one to go for. The SDK will retry internally, briefly, but under very heavy load or if something odd is happening like shard rebalancing capacity will drop and suddenly it will become very visible. If the other stuff is comparable to what's already there (i.e. not a regression, w.r.t. vector reads), then all is good, separate pr work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
