jx2lee commented on PR #1650: URL: https://github.com/apache/iceberg-go/pull/1650#issuecomment-5209958526
> This change is correct: I verified that `cmd/iceberg/main.go:361` is the CLI's only comparison of `args.Catalog`, and the value is assigned from configuration at `cmd/iceberg/main.go:884`, so config-file and environment-derived catalog types benefit as well. The normalization does not touch case-sensitive URI, warehouse, or credential values. > > Optional follow-ups: > > - **PR title:** consider correcting the two typos before squash-merge so the commit lands as `fix(cli): accept case-insensitive catalog types`. > - `cmd/iceberg/main.go:361-427`: the nearby `initCatalog` switch has no `catalog.SQL` or `catalog.DynamoDB` branch even though both are declared catalog types. This is pre-existing, but it may be worth tracking separately. thanks for the review and comment 🎶! I'll follow up seperately for missing catalog type in CLI! (dynamo and sql type) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
