moomindani commented on PR #3474: URL: https://github.com/apache/iceberg-python/pull/3474#issuecomment-5211043961
Not stale — still active and waiting for review. Status: CI green (17/17), mergeable, and all review comments so far are answered. The three open threads are all replies from me awaiting confirmation: - `puffin.py` — kept `PuffinWriter` as a generic format-level writer with DV serialization on `DeletionVector.to_blob()`, following the #3491 discussion. - `puffin.py` — `overwrite=True` is for idempotency, matching the other write-once writers (`pyarrow.py`, `avro/file.py`). - `deletion_vector.py` — fixed the key bound to match Java's `readKey` (`> Integer.MAX_VALUE - 1`), so we can no longer write a DV that Java cannot read. Thanks @rambleraptor for catching that. @sungwy you reviewed the earlier rounds — would you mind taking another look? @ebyhr @rambleraptor if the resolutions above look right to you, marking those threads resolved would help move this along. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
