moomindani commented on PR #3631: URL: https://github.com/apache/iceberg-python/pull/3631#issuecomment-5213495996
Marking this ready for review. I had kept it as a draft to land consistently with #3124, which adds `compact()` to the same `MaintenanceTable`. Revisiting that: the two PRs add separate methods and do not conflict in code, so the only thing to align is naming and argument style — which whichever lands first can set for the other. #3124 has been open since March and is itself waiting on further work, so holding this indefinitely doesn't seem useful. State: CI green (17/17), mergeable, five tests using an in-memory catalog with real appends. V3 tables are rejected with a clear error for now, since rewriting must preserve `first-row-id`, which needs the read side of row lineage (#3621). @Fokko @sungwy would either of you have time to take a look? Closes #3629. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
