JosephLenton commented on code in PR #2916:
URL: https://github.com/apache/iceberg-rust/pull/2916#discussion_r3734433427
##########
crates/iceberg/src/spec/values/serde.rs:
##########
@@ -238,7 +239,11 @@ pub(crate) mod _serde {
PrimitiveLiteral::Double(v) => RawLiteralEnum::Double(v.0),
PrimitiveLiteral::String(v) => RawLiteralEnum::String(v),
PrimitiveLiteral::UInt128(v) => {
Review Comment:
I have made that change (to apply the work `avro/schema.rs` instead of
`values/serde.rs`), and it makes a lot more sense.
However I am finding if I use `{"type": "fixed", "size": 16}` works, but
`{"type": "fixed", "size": 16, "logicalType": "uuid"}` causes Avro to panic.
The latter I am pretty certain I see Java using here:
https://github.com/apache/iceberg/blob/0d60b2bb8780d781f4ceb69032418d222b649ae5/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java#L54-L55
I am wondering if a change is needed in Avro on this. I am going to have to
go away and investigate further and come back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
