uros-b commented on code in PR #17540:
URL: https://github.com/apache/iceberg/pull/17540#discussion_r3735209704
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -213,8 +213,10 @@ public <T extends S3CrtAsyncClientBuilder> void
applyClientCredentialConfigurati
public AwsCredentialsProvider credentialsProvider(
String accessKeyId, String secretAccessKey, String sessionToken) {
if (!Strings.isNullOrEmpty(this.clientCredentialsProvider)) {
- clientCredentialsProviderProperties.put(
- VendedCredentialsProvider.URI, refreshCredentialsEndpoint);
+ if (!Strings.isNullOrEmpty(refreshCredentialsEndpoint)) {
+ clientCredentialsProviderProperties.put(
+ VendedCredentialsProvider.URI, refreshCredentialsEndpoint);
+ }
Review Comment:
Please add a proper regression test (e.g. in TestAwsClientProperties)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
