zakariya-s commented on code in PR #2932:
URL: https://github.com/apache/iceberg-rust/pull/2932#discussion_r3735944694
##########
crates/catalog/rest/src/client.rs:
##########
@@ -71,6 +75,24 @@ impl HttpClient {
})
}
+ /// Create a client for table-scoped resources while reusing this client's
+ /// underlying connection pool.
+ ///
+ /// A load-table response may supply a table token or `header.*` values
that
+ /// must be used for subsequent table requests such as credential refresh.
+ pub(crate) fn for_table(
+ &self,
+ catalog_uri: &str,
+ props: HashMap<String, String>,
+ ) -> Result<Self> {
+ let cfg = RestCatalogConfig::builder()
+ .uri(catalog_uri.to_string())
+ .props(props)
+ .client(Some(self.client.clone()))
+ .build();
+ Self::new(&cfg)
+ }
Review Comment:
Good idea, I missed this. The cached token was made shareable and
`for_table()` constructs a table client manually instead of through
`HttpClient::new()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
