yyanyy commented on a change in pull request #1975:
URL: https://github.com/apache/iceberg/pull/1975#discussion_r552347390



##########
File path: api/src/main/java/org/apache/iceberg/ContentFile.java
##########
@@ -141,4 +141,13 @@
    *         null value counts, or nan value counts
    */
   F copyWithoutStats();
+
+  /**
+   * Returns the sort order id of this file, which describes how the file is 
ordered.
+   * This information will be useful for merging data and equality delete 
files more efficiently
+   * when they share the same sort order id.
+   */
+  default Integer sortOrderId() {

Review comment:
       I was thinking to add it to ensure backward compatibility in case people 
implement their own `ContentFile`, do you think it's unlikely so it's safe for 
us to not have default? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to